Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sample cross-fork PR #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Sample cross-fork PR #3

wants to merge 1 commit into from

Conversation

mweberxyz
Copy link
Owner

Ignore files changes, just grabbed a recent clean PR into fastify/fastify -- do not merge.

Adding benchmark tag to demonstrate cross-fork benchmark workflow.

Repository owner deleted a comment from github-actions bot Feb 25, 2024
@github-actions GitHub Actions
Copy link

Benchmark Node 16 PR Node 16 Base Node 18 PR Node 18 Base Node 20 PR Node 20 Base
parser.js 48152 48990 41876 41320 41313 39224
simple.js 55606 54070 46836 45468 44472 45680
hooks-benchmark.js 65436 64412 54198 52694 52355 55625
hooks-benchmark-async-await.js 36753 35278 31980 32336 39051 42465

Warnings

  • Non-200 responses returned for parser.js on pr branch on Node 16
  • Non-200 responses returned for parser.js on pr branch on Node 18
  • Non-200 responses returned for parser.js on pr branch on Node 20

@mweberxyz mweberxyz mentioned this pull request Feb 25, 2024
Open
@github-actions GitHub Actions
Copy link

Benchmark Node 16 PR Node 16 Base Node 18 PR Node 18 Base Node 20 PR Node 20 Base
parser.js 14147 14410 13521 13516 13626 12754
simple.js 15353 15259 14316 14644 14390 14450
hooks-benchmark.js 16154 16334 15822 15557 15760 14782
hooks-benchmark-async-await.js 7128 8675 7241 6941 8627 8433

Warnings

  • Non-200 responses returned for parser.js on pr branch on Node 16
  • Non-200 responses returned for parser.js on pr branch on Node 18
  • Non-200 responses returned for parser.js on pr branch on Node 20

@github-actions GitHub Actions
Copy link

Benchmark Node 16 PR Node 16 Base Node 18 PR Node 18 Base Node 20 PR Node 20 Base
parser.js 59305 48481 37249 30416 38571 33060
simple.js 65577 65974 40376 40193 42203 42270
hooks-benchmark.js 66825 65980 43944 41937 46830 44046
hooks-benchmark-async-await.js 32699 33358 23172 25000 30873 28398

Warnings

  • Non-200 responses returned for parser.js on pr branch on Node 16
  • Non-200 responses returned for parser.js on pr branch on Node 18
  • Non-200 responses returned for parser.js on pr branch on Node 20

@github-actions GitHub Actions
Copy link

Benchmark Node 16 PR Node 16 Base Node 18 PR Node 18 Base Node 20 PR Node 20 Base
parser.js 42565 35304 54974 45135 39229 35192
simple.js 47573 45721 59667 58329 44159 42752
hooks-benchmark.js 49652 46652 62401 64663 49780 48002
hooks-benchmark-async-await.js 22973 23762 41080 31603 29685 29966

Warnings

  • Non-200 responses returned for parser.js on pr branch on Node 16
  • Non-200 responses returned for parser.js on pr branch on Node 18
  • Non-200 responses returned for parser.js on pr branch on Node 20

@github-actions GitHub Actions
Copy link

Benchmark Node 16 PR Node 16 Base Node 18 PR Node 18 Base Node 20 PR Node 20 Base
parser.js 48436 42883 59130 49656 43878 39780
simple.js 51614 52777 61926 63215 47417 48801
hooks-benchmark.js 56384 56678 67301 64894 53876 52213
hooks-benchmark-async-await.js 26312 26836 48223 35109 34892 37074

Warnings

  • Non-200 responses returned for parser.js on pr branch on Node 16
  • Non-200 responses returned for parser.js on pr branch on Node 18
  • Non-200 responses returned for parser.js on pr branch on Node 20

@github-actions GitHub Actions
Copy link

Benchmark Node 16 PR Node 16 Base Node 18 PR Node 18 Base Node 20 PR Node 20 Base
parser.js 48253 41923 43640 37291 61159 52272
simple.js 53041 52456 46961 48543 63910 65712
hooks-benchmark.js 58334 55414 49227 52162 68122 68899
hooks-benchmark-async-await.js 30190 27276 28050 27940 42803 45977

Warnings

  • Non-200 responses returned for parser.js on pr branch on Node 16
  • Non-200 responses returned for parser.js on pr branch on Node 18
  • Non-200 responses returned for parser.js on pr branch on Node 20

@github-actions GitHub Actions
Copy link

Benchmark Node 16 PR Node 16 Base Node 18 PR Node 18 Base Node 20 PR Node 20 Base
parser.js 43711 35519 40639 34559 55135 45951
simple.js 48415 48415 43103 42623 62975 61087
hooks-benchmark.js 51903 51679 46335 47647 61215 64159
hooks-benchmark-async-await.js 24591 24367 24879 24751 42399 38591

Warnings

  • Non-200 responses returned for parser.js on pr branch on Node 16
  • Non-200 responses returned for parser.js on pr branch on Node 18
  • Non-200 responses returned for parser.js on pr branch on Node 20

@github-actions GitHub Actions
Copy link

Benchmark Node 16 PR Node 16 Base Node 18 PR Node 18 Base Node 20 PR Node 20 Base
parser.js 50623 49983 44799 44607 45887 44735
simple.js 57599 56895 49343 49023 50463 50207
hooks-benchmark.js 65727 65311 56319 57471 57247 58527
hooks-benchmark-async-await.js 33567 33055 33311 34655 41759 42015

Warnings

  • Non-200 responses returned for parser.js on pr branch on Node 16
  • Non-200 responses returned for parser.js on pr branch on Node 18
  • Non-200 responses returned for parser.js on pr branch on Node 20

@github-actions GitHub Actions
Copy link

Benchmark Node 16 PR Node 16 Base Node 18 PR Node 18 Base Node 20 PR Node 20 Base
hooks-benchmark-async-await.js 35530.91 36940.37 36096.73 36429.6 46678.4 46080
hooks-benchmark.js 65832 68744 59417.6 59964.8 59672.73 61005.1
parser.js 51137.46 51956 45863.28 44188 44678.55 45839.28
simple.js 58148.37 58552.73 49005.1 49625.6 49328 49336.73

Warnings

  • Non-200 responses returned for parser.js on pr branch on Node 16 (run 1)
  • Non-200 responses returned for parser.js on pr branch on Node 16 (run 2)
  • Non-200 responses returned for parser.js on pr branch on Node 16 (run 3)
  • Non-200 responses returned for parser.js on pr branch on Node 18 (run 1)
  • Non-200 responses returned for parser.js on pr branch on Node 18 (run 2)
  • Non-200 responses returned for parser.js on pr branch on Node 18 (run 3)
  • Non-200 responses returned for parser.js on pr branch on Node 20 (run 1)
  • Non-200 responses returned for parser.js on pr branch on Node 20 (run 2)
  • Non-200 responses returned for parser.js on pr branch on Node 20 (run 3)

@gurgunday gurgunday deleted the type branch March 1, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mweberxyz @gurgunday